Skip to content

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Dec 20, 2024

As in title

side note: don't care about commit message ;-)

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) December 20, 2024 08:19
@russelljtdyer russelljtdyer added Language checking English language and AsciiDoc formatting checking is in progress Language checked English language and AsciiDoc formatting checks done and removed Language unchecked Language checking English language and AsciiDoc formatting checking is in progress labels Jan 6, 2025
@MarcinVaadin MarcinVaadin requested a review from jouni January 7, 2025 07:25
@peholmst
Copy link
Member

peholmst commented Aug 8, 2025

What's the status of this PR?

@peholmst peholmst added target/main cherry pick to main branch Stale Unless the PR is reviewed and merged, it will be discarded as stale. and removed Stale Unless the PR is reviewed and merged, it will be discarded as stale. labels Aug 8, 2025
@MarcinVaadin MarcinVaadin force-pushed the docs/copilot-feature-flag branch from e657607 to a23bb42 Compare August 8, 2025 08:40
Copy link

github-actions bot commented Aug 8, 2025

AI Language Review

  • In the "Feature Flags" section of the file, the new feature copilotExperimentalFeatures has been added but lacks a "Learn More" link similar to the masterDetailLayoutComponent. It would be helpful to include a link or reference for users to get additional details.
  • In the "Limitations" section, a note has been added about experimental features needing the copilotExperimentalFeatures feature flag. However, the explanation feels abrupt. Consider adding a brief context or explanation on what this flag does or how it integrates with the rest of the system.

@MarcinVaadin
Copy link
Member Author

What's the status of this PR?

Suggestions applied, ready for review

@MarcinVaadin MarcinVaadin requested review from jouni and emarc August 8, 2025 08:42
@peholmst
Copy link
Member

@MarcinVaadin There is now a merge conflict. Can you fix it? I'll ping the reviewers afterwards so that we can get this merged.

@MarcinVaadin MarcinVaadin force-pushed the docs/copilot-feature-flag branch from a23bb42 to 3133298 Compare August 26, 2025 11:08
@MarcinVaadin
Copy link
Member Author

@peholmst done

@MarcinVaadin MarcinVaadin merged commit f92415a into v24 Aug 26, 2025
3 of 4 checks passed
@MarcinVaadin MarcinVaadin deleted the docs/copilot-feature-flag branch August 26, 2025 11:12
@vaadin-bot
Copy link
Contributor

Hi @MarcinVaadin and @MarcinVaadin, when i performed cherry-pick to this commit to main, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f92415a
error: could not apply f92415a... Copilot feature flags update (#4037)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked-main copilot Language checked English language and AsciiDoc formatting checks done target/main cherry pick to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants